85803[TASK] Remove deprecated "srcsetAttr" in DefaultSanitizerBuilder
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Wouter Wolters uploaded patch set 1 08/28/24, 09:16
-
core-ci voted on patch set 1 V -1 08/28/24, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64395
-
core-ci voted on patch set 1 V +1 08/28/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64395
-
Simon Praetorius commented on patch set 1 09/04/24, 17:20
Do we need to apply this to v12? -
Wouter Wolters commented on patch set 1 09/04/24, 18:56
Reply
as v12 uses the same HTML sanitizer version I decided to add this small change also for v12. -
Benni Mack updated the commit message in patch set 2
V +110/18/24, 13:48 -
Christian Kuhn uploaded patch set 3 01/14/25, 15:31
-
Christian Kuhn commented on patch set 3 CR +1 V +1 01/14/25, 15:32
Reply
let's not backport this to v12 anymore. -
Stefan Bürk voted on patch set 3 CR +1 V +1 01/14/25, 15:36
-
core-ci voted on patch set 3 V +1 01/14/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72465
-
Oliver Hader commented on patch set 3 01/14/25, 15:55
Anybody please create a PR for the upstream html-sanitizer, dropping the property completely? If it is dropped, we can finally be sure it is not used anymore. -
Christian Kuhn commented on patch set 3 01/14/25, 16:03
Reply
is this considered breaking for typo3/html-sanitizer and thus forces a new major, which may need some branch preparations? -
Christian Kuhn commented on patch set 3 01/14/25, 16:14
-
Christian Kuhn voted on patch set 3 CR +2 V +2 01/14/25, 16:30
-
Christian Kuhn merged patch set 4 01/14/25, 16:30