Review main Merged

85821[TASK] Extract a hardcoded fluid template source to file

Christian Kuhn CR +2 V +2 Easy +12 −2 updated 08/28/24, 22:41

Commit message

Hard coded fluid code within the framework (except
in fluid view helper tests) is not a good thing:
It makes substituting the view with something
else impossible.
The patch extracts a setTemplateSource() to a file.
This is a pre-patch to a general view factory
implementation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/28/24, 22:12

  2. core-ci voted on patch set 1 V +1 08/28/24, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64440

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 08/28/24, 22:20

  4. Benni Mack voted on patch set 1 CR +1 V +1 08/28/24, 22:32

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 08/28/24, 22:41

  6. Christian Kuhn merged patch set 2 08/28/24, 22:41