85826[TASK] Remove orphaned language keys in locallang_misc.xlf of EXT:core
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
- Benni Mack +1
Issues 1
Files 1
Review log 1824
-
Jasmina Ließmann uploaded patch set 1 08/29/24, 20:44
-
core-ci voted on patch set 1 V +1 08/29/24, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64497
-
Jasmina Ließmann uploaded patch set 2
V +109/19/24, 20:31 -
core-ci voted on patch set 2 V +1 09/19/24, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66253
-
Jasmina Ließmann uploaded patch set 3
V +109/19/24, 23:00 -
core-ci voted on patch set 3 V +1 09/19/24, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66266
-
Christian Kuhn voted on patch set 3 CR +1 V +1 09/19/24, 23:12
-
Georg Ringer commented on patch set 3 CR -1 09/20/24, 05:53
i really don't like this change TBH. feel free to overrule my -1, but people are using those keys and those are translated as well. just throwing it aways doesn't help anyone -
Garvin Hicking commented on patch set 3 09/20/24, 06:25
I feel a bit unsafe/unsure. I did search all the code for usages, and checked codesearch, and the javascript files. I only found one usage. I'm unsure if non-public third-party extensions have used this, but I'd tend to lean towards "then provide your own labels". Having a leaner language file would make it easier to see what the core uses, I do see a benefit of this. Need to think some more on it, not blocking though.locallang_misc.xlf:119This is used in ShortcutRepository.php: $label = $languageService->sL($languageFile . ':bookmark_group') . ' ' . abs($groupId); -
Georg Ringer commented on patch set 3 09/20/24, 10:56
I am fine for v14, but not now in 13 -
Andreas Kienast commented on patch set 3 09/20/24, 10:58
Reply
I'd arguably keep `goBack`. All other labels to be removed are clearly scoped. Using them anyway should raise a bad gut feeling from the beginning. -
Jasmina Ließmann uploaded patch set 4
CR +1V +109/20/24, 12:18 -
Jasmina Ließmann commented on patch set 3 09/20/24, 12:20
Reply
I added the language key `goBack` again.locallang_misc.xlf:119ReplyThanks, the language key is now restored. -
core-ci voted on patch set 4 V +1 09/20/24, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66327
-
Jasmina Ließmann commented on patch set 4 V -1 09/25/24, 09:14
postponed to v14 -
Simon Schaufelberger uploaded patch set 5
V +112/17/24, 19:05 -
core-ci voted on patch set 5 V +1 12/17/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71313
-
Simon Schaufelberger rebased onto patch set 6
V +101/29/25, 15:56 -
Benni Mack voted on patch set 6 CR +1 V +1 01/29/25, 15:56
-
Benni Mack commented on patch set 6 01/29/25, 15:57
I went through most of the options, and I think it's safe to remove them for v14... -
Christian Kuhn voted on patch set 6 CR +1 V +1 01/29/25, 15:59
-
Jasmina Ließmann voted on patch set 6 CR +2 V +2 01/29/25, 16:00
-
Jasmina Ließmann merged patch set 7 01/29/25, 16:00
-
core-ci voted on patch set 6 V +1 01/29/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73147