85835[TASK] Convert ViewHelper test to functional
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Simon Praetorius uploaded patch set 1 08/30/24, 19:52
-
core-ci voted on patch set 1 V -1 08/30/24, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64554
-
Simon Praetorius uploaded patch set 2
V -108/30/24, 20:29 -
core-ci voted on patch set 2 V +1 08/30/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64556
-
Garvin Hicking commented on patch set 2 08/30/24, 20:53
-
Stefan Bürk commented on patch set 2 08/30/24, 20:57
TargetPageIdViewHelperTest.php:29I guess we couly also use ``` protected bool $initializeDatabase = false; ``` for now, but not tested.TargetPageIdViewHelperTest.php:34ReplyYes, we should change that in the same go to named arguments (array keys matching testmethod parameter names). -
Stefan Bürk commented on patch set 2 08/30/24, 20:59
TargetPageIdViewHelperTest.php:29ReplyForgot this. Followup change should add further testcases needing DB iniitialzation, does notmatter for these two test execution meanwhile. -
Stefan Bürk commented on patch set 3
V +108/30/24, 21:17Published edit on patch set 2. -
Stefan Bürk commented on patch set 3 08/30/24, 21:17
TargetPageIdViewHelperTest.php:34ReplyDone -
Stefan Bürk uploaded patch set 4 08/30/24, 21:20
-
Stefan Bürk voted on patch set 4 CR +1 V +1 08/30/24, 21:24
-
core-ci voted on patch set 3 V -1 08/30/24, 21:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64558
-
core-ci voted on patch set 4 V +1 08/30/24, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64559
-
Christian Kuhn voted on patch set 4 CR +2 V +2 08/31/24, 06:10
-
Christian Kuhn merged patch set 5 08/31/24, 06:10
TargetPageIdViewHelperTest.php:34