Review main Merged

85835[TASK] Convert ViewHelper test to functional

Simon Praetorius CR +2 V +2 Normal +53 −46 updated 08/31/24, 06:10

Commit message

A ViewHelper shouldn't be called directly in a test case because
its behavior is highly dependent on Fluid.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Simon Praetorius uploaded patch set 1 08/30/24, 19:52

  2. core-ci voted on patch set 1 V -1 08/30/24, 20:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64554

  3. Simon Praetorius uploaded patch set 2 V -1 08/30/24, 20:29

  4. core-ci voted on patch set 2 V +1 08/30/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64556

  5. Garvin Hicking commented on patch set 2 08/30/24, 20:53

    TargetPageIdViewHelperTest.php:34

    maybe better use named array keys matching the test method for forward compatibility
  6. Stefan Bürk commented on patch set 2 08/30/24, 20:57

    TargetPageIdViewHelperTest.php:29

    I guess we couly also use ``` protected bool $initializeDatabase = false; ``` for now, but not tested.

    TargetPageIdViewHelperTest.php:34 Reply

    Yes, we should change that in the same go to named arguments (array keys matching testmethod parameter names).
  7. Stefan Bürk commented on patch set 2 08/30/24, 20:59

    TargetPageIdViewHelperTest.php:29 Reply

    Forgot this. Followup change should add further testcases needing DB iniitialzation, does notmatter for these two test execution meanwhile.
  8. Stefan Bürk commented on patch set 3 V +1 08/30/24, 21:17

    Published edit on patch set 2.
  9. Stefan Bürk commented on patch set 3 08/30/24, 21:17

    TargetPageIdViewHelperTest.php:34 Reply

    Done
  10. Stefan Bürk uploaded patch set 4 08/30/24, 21:20

  11. Stefan Bürk voted on patch set 4 CR +1 V +1 08/30/24, 21:24

  12. core-ci voted on patch set 3 V -1 08/30/24, 21:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64558

  13. core-ci voted on patch set 4 V +1 08/30/24, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64559

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 08/31/24, 06:10

  15. Christian Kuhn merged patch set 5 08/31/24, 06:10