Review main Merged

85897[TASK] Remove unused typeicon "script" definition

Oli Bartsch CR +2 V +2 Easy +0 −1 updated 09/05/24, 09:55

Commit message

The "script" typeicon definition is removed since
no such CType exists.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 09/05/24, 09:32

  2. core-ci voted on patch set 1 V -1 09/05/24, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64850

  3. Oliver Hader voted on patch set 1 CR +1 V +1 09/05/24, 09:48

  4. Oliver Hader commented on patch set 1 09/05/24, 09:49

    https://github.com/TYPO3/typo3/blob/TYPO3_3-8/typo3/sysext/css_styled_content/static/setup.txt#L1072-L1081 `tt_content.script` was disabled in TYPO3 v3.8 already... let's drop it 😊
  5. core-ci voted on patch set 1 V +1 09/05/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64850

  6. Benni Mack voted on patch set 1 CR +1 V +1 09/05/24, 09:50

  7. Benni Mack voted on patch set 1 CR +2 V +2 09/05/24, 09:55

  8. Benni Mack merged patch set 2 09/05/24, 09:55