Review main Merged

85914[TASK] Make treelist context aware

Benjamin Kott CR +2 V +2 Normal +64 −52 updated 09/09/24, 11:58

Commit message

The new panel treelist styling is context aware
and adapts to light and dark color schemes. This
patch also restores the visibility of treelines
in Pagetree overview and Localization overview.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1419

  1. Benjamin Kott uploaded patch set 1 09/06/24, 13:18

  2. core-ci voted on patch set 1 V +1 09/06/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64958

  3. Benjamin Kott uploaded patch set 2 V +1 09/06/24, 13:48

  4. Benjamin Kott uploaded patch set 3 09/06/24, 13:50

  5. core-ci voted on patch set 2 V +1 09/06/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64962

  6. core-ci voted on patch set 3 V +1 09/06/24, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64963

  7. Georg Ringer voted on patch set 3 CR +1 V +1 09/06/24, 17:44

  8. Jasmina Ließmann commented on patch set 3 CR -1 V -1 09/06/24, 22:16

    Statistic.html:131

    Why reducing the button size here? In other places like EXT:recycler, "Info" or "List" module the normal/default button size is used. It should stay the same here.
  9. Benjamin Kott commented on patch set 3 09/07/24, 01:02

    Statistic.html:131 Reply

    Button size is reduced here, because the treeicons need to fill the cell. The size has already been adopted in this patch, keeping the bigger size would need an even bigger increase. This will bloat up the table even more and make consume unnecessary space. Smaller slightly buttons here fixes the view with only a slight increase in normal listings.
  10. Benjamin Kott commented on patch set 3 CR -1 09/07/24, 01:05

  11. Jasmina Ließmann commented on patch set 3 09/07/24, 10:07

    Statistic.html:131 Reply

    The current button size in "Detailed statistics" is the same as in "Pagetree Overview" of the "Info" module. I don't see any visible difference. If the button size for treeline tables is/should be changed, it should be the same in all occurrences (done in a standalone patch). Furthermore, both changes made in Statistic.html are outside the scope of this patch (context awareness) and shouldn't therefore be part of it.
  12. Benjamin Kott uploaded patch set 4 CR +1 V +1 09/09/24, 08:09

  13. Benjamin Kott commented on patch set 4 09/09/24, 08:11

    Statistic.html:131 Reply

    Mentioned views are now fixed, treeline icons were not visible at all ... Views are adjusted and mentioned in the commmit message.
  14. core-ci voted on patch set 4 V +1 09/09/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65063

  15. Benjamin Franzke uploaded patch set 5 V +1 09/09/24, 11:40

  16. Oli Bartsch voted on patch set 5 CR +1 V +1 09/09/24, 11:47

  17. core-ci voted on patch set 5 V +1 09/09/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65086

  18. Andreas Kienast voted on patch set 5 CR +2 V +2 09/09/24, 11:58

  19. Andreas Kienast merged patch set 6 09/09/24, 11:58