Review main Merged

85930[DOCS] Add trailing backtick to php-role

TYPO3com CR +2 V +2 Easy +1 −1 updated 09/09/24, 17:57

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. TYPO3com uploaded patch set 1 09/09/24, 17:26

  2. core-ci voted on patch set 1 V +1 09/09/24, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65125

  3. Stefan Bürk commented on patch set 1 09/09/24, 17:37

    comma is not correct. It's a back-tick, backquote, grave, or grave accent which is added in the example for the php-role See: https://en.wikipedia.org/wiki/Backtick

    Deprecation-104789-RenderStaticForFluidViewHelpers.rst:136

    Why do you add this here ? It make no sense note that explitcitly. First, it **should** be obsolet anyway in most cases and removed by CGL (php-cs-fixer) because of beeing unused. But if a ViewHelper implementation has a submethod handing over the context in some way and has typehints, this remark may be confusing as they try to remove it thinking to be removed/obsolete/deprecated.
  4. Lina Wolf updated the commit message in patch set 2 V +1 09/09/24, 17:38

  5. Lina Wolf commented on patch set 2 09/09/24, 17:41

    Reply

    Yes sorry, backtick of course

    Deprecation-104789-RenderStaticForFluidViewHelpers.rst:136 Reply

    I did not change any of the changelog entry but merely corrected the syntax causing a rendering error as the trailing backtick is missing Something like this ":php:" is printed here: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Deprecation-104789-RenderStaticForFluidViewHelpers.html#deprecation-104789-renderstatic-for-fluid-viewhelpers
  6. core-ci voted on patch set 2 V +1 09/09/24, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65126

  7. Stefan Bürk commented on patch set 2 09/09/24, 17:49

    Deprecation-104789-RenderStaticForFluidViewHelpers.rst:136 Reply

    You are right.
  8. Stefan Bürk updated the commit message in patch set 3 V +1 09/09/24, 17:49

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 09/09/24, 17:49

  10. core-ci voted on patch set 3 V +1 09/09/24, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65128

  11. Benni Mack voted on patch set 3 CR +2 V +2 09/09/24, 17:57

  12. Benni Mack merged patch set 4 09/09/24, 17:57