Review main Merged

85977[BUGFIX] Undefined array key "contentSecurityPolicies"

Thomas Hohn CR +2 V +2 Easy +2 −2 updated 09/10/24, 18:29

Commit message

If the 'contentSecurityPolicies' value is not filled properly
in the site configuration, the call to
$site->getConfiguration()['contentSecurityPolicies'] will fail.
The access should we guarded with a null coalescing operator.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Thomas Hohn uploaded patch set 1 09/10/24, 10:03

  2. core-ci voted on patch set 1 V -1 09/10/24, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65206

  3. core-ci voted on patch set 1 V +1 09/10/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65206

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 09/10/24, 10:36

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 09/10/24, 11:49

  6. Benni Mack commented on patch set 1 CR -1 09/10/24, 12:52

    Should also happen in MutationRepository
  7. Benni Mack commented on patch set 1 09/10/24, 12:54

    How can I reproduce this?
  8. Thomas Hohn uploaded patch set 2 CR +1 V +1 09/10/24, 13:15

  9. Thomas Hohn commented on patch set 2 09/10/24, 13:20

    Reply

    Hi - I'm kind of unsure if this is only a problem for "me" or it's a general problem since we don't use the yaml files for site configuration. So my best guess would be a "faulty" file with that config missing maybe. I just added the issue and patch in case others run into the same issue.
  10. core-ci voted on patch set 2 V +1 09/10/24, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65251

  11. Benni Mack commented on patch set 2 CR +1 V +1 09/10/24, 13:30

    Reply

    Done
  12. Garvin Hicking voted on patch set 2 CR +1 V +1 09/10/24, 13:55

  13. Benni Mack voted on patch set 2 CR +2 V +2 09/10/24, 14:38

  14. Benni Mack merged patch set 3 09/10/24, 14:38

  15. Oliver Hader commented on patch set 3 CR +1 09/10/24, 18:29

    More a `TASK` than a `BUGFIX` - anyway it's fine