86006[TASK] Add functional tests for SysNoteRepository
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 913
-
Garvin Hicking uploaded patch set 1 09/11/24, 09:06
-
core-ci voted on patch set 1 V -1 09/11/24, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65394
-
core-ci commented on patch set 1 09/11/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65394
-
Garvin Hicking uploaded patch set 2
V -109/11/24, 09:20Use proper sort order -
core-ci voted on patch set 2 V +1 09/11/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65396
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 09/14/24, 09:58
-
Stefan Bürk commented on patch set 2 CR -1 09/14/24, 23:49
SysNoteRepositoryTest.php:61`assertSame()` and not `assertEqual()` strict <-> not-strict comparisionSysNoteRepositoryTest.php:91`assertSame()` and not `assertEqual()` strict <-> not-strict comparision -
Stefan Bürk uploaded patch set 3
CR +1V +109/14/24, 23:52 -
Stefan Bürk commented on patch set 3 09/14/24, 23:52
SysNoteRepositoryTest.php:61ReplyDoneSysNoteRepositoryTest.php:91ReplyDone -
core-ci voted on patch set 3 V +1 09/14/24, 23:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65774
-
Stefan Bürk voted on patch set 3 CR +1 V +1 09/15/24, 03:21
-
Anja Leichsenring voted on patch set 3 CR +2 V +2 09/15/24, 08:49
-
Anja Leichsenring merged patch set 4 09/15/24, 08:49