86019[TASK] Improve LatestChangedPages dashboard widget
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104878-IntroduceDashboardWidgetForPagesWithLatestChanges.rst+4 −0
- typo3/sysext/dashboard/Classes/Widgets/LatestChangedPagesWidget.php16+80 −28
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf+12 −6
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/LatestChangedPagesWidget.html+13 −7
Review log 2638
Show 813 earlier messages
-
Frank Nägler uploaded patch set 1 09/11/24, 14:12
-
core-ci voted on patch set 1 V +1 09/11/24, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65461
-
Frank Nägler updated the commit message in patch set 2
V +109/11/24, 20:41 -
core-ci voted on patch set 2 V +1 09/11/24, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65495
-
Stefan Bürk updated the commit message in patch set 3
V +109/11/24, 23:33 -
core-ci voted on patch set 3 V +1 09/11/24, 23:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65509
-
Oli Bartsch uploaded patch set 4
V +109/12/24, 14:30 -
core-ci voted on patch set 4 V +1 09/12/24, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65581
-
Frank Nägler uploaded patch set 5
V +109/12/24, 15:56 -
core-ci voted on patch set 5 V +1 09/12/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65590
-
Oli Bartsch commented on patch set 5 09/12/24, 16:25
LatestChangedPagesWidget.php:165ParameterType should be set to `Connection::PARAM_INT`LatestChangedPagesWidget.php:175ParameterType should be set to `Connection::PARAM_INT`LatestChangedPagesWidget.php:176ParameterType should be set to `Connection::PARAM_INT`LatestChangedPagesWidget.php:227Shouldn't this be `pages`? -
Frank Nägler uploaded patch set 6
V +109/12/24, 18:34 -
Frank Nägler commented on patch set 5 09/12/24, 18:35
LatestChangedPagesWidget.php:159ReplyAcknowledgedLatestChangedPagesWidget.php:165ReplyAcknowledgedLatestChangedPagesWidget.php:175ReplyAcknowledgedLatestChangedPagesWidget.php:176ReplyAcknowledgedLatestChangedPagesWidget.php:227ReplyAcknowledged
-
core-ci voted on patch set 6 V +1 09/12/24, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65599
-
Benjamin Franzke commented on patch set 6 09/12/24, 19:03
Isn't this a FOLLOWUP? cc @bo@cedev.de -
Oli Bartsch commented on patch set 6 09/12/24, 19:08
Reply
Hi @ben@bnf.dev, Interesting question. I was about to make the same mistake by comparing with the initial patch. However, after a bit of consideration, I'm now quite sure there has been fixed a bit to much. This for sure qualifies as a full bugfix. -
Benjamin Franzke commented on patch set 6 09/12/24, 19:23
Reply
Ah, sounds good. Thanks you very much for the detailed answer. Have a nice evening and bon appetit. -
Benjamin Franzke uploaded patch set 7
V +109/13/24, 07:37 -
core-ci voted on patch set 7 V +1 09/13/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65633
-
Ulrich Mathes uploaded patch set 8
CR +1V +109/13/24, 08:47 -
core-ci voted on patch set 8 V +1 09/13/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65640
-
Stefan Bürk commented on patch set 8 09/14/24, 01:14
This widget has issues with workspaces (not directly): * switch to non-live workspace * edit a page and save the change in the workspace * view dashboard / widget => okay, change is displaye * switch to live workspace and than the dashboard again => broken (no information can be loaded). This is related to a broken rootline exception thrown by the RootlineUtility and in my case, admin and be debug mode the ajax is broken displaying the stack trace. Not sure if we should at least display the changes first only for the current workspace or workspace + liveworkspace or something else and investigate that bug later along with general workspace handling ? What do you think ?LatestChangedPagesWidget.php:178Please add `->setMaxResults(1)`LatestChangedPagesWidget.php:188Please add `->setMaxResults(1)` -
Stefan Bürk commented on patch set 8 09/14/24, 01:26
LatestChangedPagesWidget.php:194I guess a custom context instance should be created and passed to the rootline utility to fetch the rootline for a page in the workspace it has been changed. Not sure if this is the rootline issue mentioned in the other comment. -
Stefan Bürk uploaded patch set 9
V +109/14/24, 02:50 -
core-ci voted on patch set 9 V +1 09/14/24, 02:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65722
-
Stefan Bürk uploaded patch set 10
V +109/14/24, 03:15 -
Stefan Bürk commented on patch set 10 09/14/24, 03:20
Reply
For fetching the sys_history records the prepare querybuilder method removed all restrictions and readded the workspace restriction. That restriction does not apply for `sys_history` because that table is not TCA managed and "literally" not workspace aware. The workspace field is just a plain log. To solve this, removed adding that restriction back again and added the current workspace id filtering (where) to the query build up for the sys_history entries.LatestChangedPagesWidget.php:178ReplyDoneLatestChangedPagesWidget.php:188ReplyDoneLatestChangedPagesWidget.php:194ReplyDoes not matter - the issue was another, and current workspace rootline is okay. -
core-ci voted on patch set 10 V +1 09/14/24, 03:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65724
-
Frank Nägler uploaded patch set 11
V +109/15/24, 14:19 -
core-ci voted on patch set 11 V +1 09/15/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65815
-
Frank Nägler commented on patch set 11 09/16/24, 09:30
Reply
Do you fixed it? I can't reproduce your comments with the latest patch set. -
Stefan Bürk commented on patch set 11 09/16/24, 11:51
Reply
Should be fine. Close it for now. If I find the time right in time I will verify that again. -
Stefan Bürk uploaded patch set 12
V +109/16/24, 13:58 -
core-ci voted on patch set 12 V +1 09/16/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65896
-
Stefan Bürk voted on patch set 12 CR +1 V +1 09/16/24, 15:14
-
Stefan Bürk commented on patch set 12 09/16/24, 15:14
albeit it is more a bugfix right now -
Benni Mack voted on patch set 12 CR +2 V +2 09/17/24, 06:54
-
Benni Mack merged patch set 13 09/17/24, 06:54
LatestChangedPagesWidget.php:159