Review main Abandoned

86050[WIP][FEATURE] Route Enhancers: limitToPages allows for rootpage check

Benni Mack CR 0 V 0 Easy +15 −6 updated 04/21/26, 15:08

Commit message

Some enhancers should only work for e.g. the root page,
this can now be configured now via

  limitToPages: ['root']

in addition, it is now possible to use

  limitToDoktypes: [234]

to only allow enhancers on specific e.g. product page doktypes.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 09/12/24, 15:00

  2. core-ci voted on patch set 1 V +1 09/12/24, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65584

  3. Oliver Hader commented on patch set 1 09/12/24, 16:58

    PageRouter.php:470 Unresolved

    The positive check to process that page would be (in pseudo-code): `pageIdFound || (isSiteRoot && in_array('root', limitToPages)` Thus, the inversion would be: `!pageIdFound && !(isSiteRoot && in_array('root', limitToPages)` which is the same as `!pageIdFound && (!isSiteRoot || !in_array('root', limitToPages))`
  4. Benni Mack marked it work in progress 01/22/25, 11:50

  5. Benni Mack abandoned the change 04/21/26, 15:08

    won't do