Review 12.4 Merged

86052[BUGFIX] Provide current request to content element preview template

Benni Mack CR +2 V +2 Easy +4 −0 updated 09/12/24, 14:39

Commit message

The templates can be replaced by integrators via configuration.
They probably expect to be able to use the EditRecordViewHelper.
This one uses the current request for its returnUrl.

The request was missing which would lead to an
"Call to a member function getAttribute() on null" error.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benni Mack +2
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack commented on patch set 1 09/12/24, 13:39

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Preview/FluidBasedContentPreviewRenderer.php
  2. Benni Mack abandoned the change 09/12/24, 13:40

    wrong CP
  3. Benni Mack restored the change 09/12/24, 13:41

  4. Benni Mack uploaded patch set 2 09/12/24, 13:41

  5. Benni Mack marked it ready for review 09/12/24, 13:41

  6. Mathias Brodala voted on patch set 2 CR +1 V +1 09/12/24, 13:49

  7. core-ci voted on patch set 2 V +1 09/12/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65570

  8. core-ci voted on patch set 1 V -1 09/12/24, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65568

  9. core-ci voted on patch set 1 V -1 09/12/24, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65568

  10. Benni Mack voted on patch set 2 CR +2 V +2 09/12/24, 14:39

  11. Benni Mack merged patch set 3 09/12/24, 14:39