Review main Merged

86174[TASK] Add missing namespace to a PHP test fixture file

Christian Kuhn CR +2 V +2 Easy +2 −0 updated 09/18/24, 07:21

Commit message

All but one file in this test extension have a
proper namespace declaration. Add the missing one
to avoid a PSR-4 violation.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Christian Kuhn uploaded patch set 1 09/17/24, 22:43

  2. Christian Kuhn uploaded patch set 2 09/17/24, 22:44

  3. Stefan Bürk voted on patch set 2 CR +1 V +1 09/17/24, 22:48

  4. core-ci voted on patch set 2 V -1 09/17/24, 23:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66087

  5. core-ci voted on patch set 1 V -1 09/17/24, 23:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66086

  6. core-ci voted on patch set 2 V +1 09/17/24, 23:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66087

  7. Jasmina Ließmann voted on patch set 2 CR +1 V +1 09/17/24, 23:49

  8. Guido Schmechel voted on patch set 2 CR +1 V +1 09/18/24, 06:49

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 09/18/24, 07:21

  10. Stefan Bürk merged patch set 3 09/18/24, 07:21

  11. Georg Ringer voted on patch set 2 CR +2 V +2 09/18/24, 07:21