Review TYPO3_4-5 Merged

8622[BUGFIX] htmlArea RTE: Changing the text color to black does not work

Stanislas Rolland CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Solution: Fix colorToHex conversion utility

Review

  • Code review CR +2
    • Stanislas Rolland +2
    • Wouter Wolters +1
  • Verified V +2
    • Stanislas Rolland +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 4

  1. Stanislas Rolland commented on patch set 1 02/03/12, 02:04

    Thanks for testing and for reporting this error. I opened another issue for that one: #33644
  2. Stanislas Rolland commented on patch set 1 V 0 02/03/12, 02:04

    by team member; Looks good to me, approved
  3. Wouter Wolters commented on patch set 1 02/03/12, 02:04

    Verified; Looks good to me, but someone else must approve While testing this patch I got another error in JavaScript. Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIDOMRange.startContainer] ...(range.endContainer.nodeType==3&&range.endOffset==0&&range.startContainer.childN... This happens in the file: htmlarea_cumulative.js
  4. Stanislas Rolland merged patch set 1 02/03/12, 02:04