Review main Merged

86265[BUGFIX] Use correct element reference in mass action file upload

Andreas Kienast CR +2 V +2 Easy +4 −7 updated 09/24/24, 09:22

Commit message

If a file with a filename is about to get uploaded that already exist
in the file list, a modal appears that asks the user what to do with
the conflicting file.

The event handler bound to the mass action select element now references
the correct event target.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 09/23/24, 11:56

  2. core-ci voted on patch set 1 V +1 09/23/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66437

  3. Andreas Kienast uploaded patch set 2 V +1 09/23/24, 12:59

  4. Frank Nägler voted on patch set 2 CR +1 V +1 09/23/24, 13:02

  5. core-ci voted on patch set 2 V +1 09/23/24, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66440

  6. Benjamin Franzke voted on patch set 2 CR +1 09/24/24, 09:18

  7. Benjamin Franzke commented on patch set 2 CR +2 V +2 09/24/24, 09:22

    We should probably deny `event.currentTarget` in delegated RegularEvents. (somehow™)
  8. Benjamin Franzke merged patch set 3 09/24/24, 09:22