Review main Merged

86292[TASK] Use return code constants in `ConsumeMessagesCommand`

Thomas Hohn CR +2 V +2 Easy +2 −2 updated 09/24/24, 06:16

Commit message

Symfony's `Command` class provides constants for common return codes.
Those are now used in \TYPO3\CMS\Core\Command\ConsumeMessagesCommand.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Thomas Hohn uploaded patch set 1 09/24/24, 04:53

  2. core-ci voted on patch set 1 V +1 09/24/24, 04:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66473

  3. Garvin Hicking commented on patch set 1 09/24/24, 05:16

    ConsumeMessagesCommand.php:153

    should the default on line 71 also be changed from 0 to this? (couldn't place a comment in that line)
  4. Thomas Hohn commented on patch set 1 09/24/24, 05:18

    ConsumeMessagesCommand.php:153 Reply

    Acknowledged
  5. Thomas Hohn uploaded patch set 2 V +1 09/24/24, 05:19

  6. core-ci voted on patch set 2 V +1 09/24/24, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66475

  7. Benjamin Franzke voted on patch set 2 CR +1 V +1 09/24/24, 05:56

  8. Anja Leichsenring voted on patch set 2 CR +1 V +1 09/24/24, 06:03

  9. Benni Mack voted on patch set 2 CR +2 V +2 09/24/24, 06:16

  10. Benni Mack merged patch set 3 09/24/24, 06:16