86306[TASK] Remove superflous string check
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 7
-
Sascha Egerer uploaded patch set 1 09/25/24, 07:26
-
Sascha Egerer uploaded patch set 2 09/25/24, 07:26
-
Benjamin Franzke commented on patch set 2 CR -1 09/25/24, 07:30
This class does not declare strict types, I don't think this is safe right now, it's only a type-hint not an assertion. -
Sascha Egerer abandoned the change 09/25/24, 07:33
Not relevant as class does not use strict_types -
Mathias Brodala commented on patch set 2 09/25/24, 07:35
composer.json:2What is this? -
Sascha Egerer commented on patch set 2 09/25/24, 07:37
Reply
Uh you're right - im not used to code that does not use strict_types. What a pain.composer.json:2ReplyPushed by accident. So was this question related to "why did you push it" or are you interested in what it actually is? -
Mathias Brodala commented on patch set 2 09/25/24, 07:39
composer.json:2Reply UnresolvedWell, you already answered the 1st. So the 2nd would certainly be interesting. ;-) But probably not here, this is not the right platform for this.