Review main Merged

86310[TASK] Document LinkFactory throwing UnableToLinkException

Patrick Schriner CR +2 V +2 Easy +1 −0 updated 09/25/24, 12:46

Commit message

LinkFactory can throw an `UnableToLinkException` and it's the callers
responsibility to handle that exception.
A `@throws` phpdoc-tag now properly documents this.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Patrick Schriner uploaded patch set 1 09/25/24, 08:07

  2. core-ci voted on patch set 1 V +1 09/25/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66554

  3. Mathias Brodala voted on patch set 1 CR +1 09/25/24, 08:48

  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 09/25/24, 09:53

  5. Garvin Hicking commented on patch set 2 09/25/24, 09:53

    Relabelled to a task and removed 11.5 scope (LinkFactory does not exist there). Thanks :)
  6. Garvin Hicking voted on patch set 2 CR +1 V +1 09/25/24, 09:54

  7. Mathias Brodala voted on patch set 2 CR +1 09/25/24, 09:56

  8. core-ci voted on patch set 2 V +1 09/25/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66565

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 09/25/24, 10:11

  10. Oli Bartsch merged patch set 3 09/25/24, 12:46