86344[BUGFIX] Immediately apply color scheme and theme changes in user setup
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/backend/broadcast-message.ts+6 −4
- Build/Sources/TypeScript/backend/color-scheme-manager.tsdeleted+0 −39
- Build/Sources/TypeScript/backend/color-scheme-switch.ts+11 −15
- Build/Sources/TypeScript/backend/user-settings-manager.ts2new+88 −0
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+14 −0
- typo3/sysext/backend/Resources/Public/JavaScript/color-scheme-manager.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/color-scheme-switch.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/user-settings-manager.jsnew+13 −0
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+14 −0
Review log 2130
Show 45 earlier messages
-
Benjamin Franzke uploaded patch set 1 09/26/24, 08:48
-
Benjamin Franzke uploaded patch set 2 09/26/24, 08:50
-
Benjamin Franzke uploaded patch set 3 09/26/24, 08:51
-
core-ci voted on patch set 1 V +1 09/26/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66648
-
Frank Nägler commented on patch set 3 09/26/24, 08:57
With this patch, the hint "Notice! In order to activate most of these changes, please reload the backend (eg. logout and login again)." after saving can be removed, right?
-
core-ci voted on patch set 3 V +1 09/26/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66650
-
Andreas Kienast commented on patch set 3 09/26/24, 09:07
Reply
That's a tough one. This message is controlled by a flag that becomes `true` if backend user UC has changed, which is true in this case. -
Benjamin Franzke commented on patch set 3 09/26/24, 09:09
Reply
We should at least try to (but not within this patch). This notice existed at least since 2004: https://github.com/TYPO3/typo3/commit/109b1924c4180883c9ed46c97e3107a38dc18fd6 we need to track-down what's not automatically updated these days.. If there is nothing left, yes, then that can be removed. Toolbar and pagetree receive updates, so there shouldn't be much left. -
Frank Nägler commented on patch set 3 09/26/24, 09:12
Reply
okay, was just an idea. -
Benjamin Franzke commented on patch set 3 09/26/24, 09:15
Reply
I found one left-over: backendTitleFormat (not updated directly, currently needs backend refresh) -
Benjamin Franzke uploaded patch set 4
V +109/26/24, 09:16 -
core-ci voted on patch set 4 V +1 09/26/24, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66653
-
Andreas Kienast voted on patch set 4 CR +1 V +1 09/26/24, 09:24
-
Benjamin Franzke uploaded patch set 5
CR +1V +109/26/24, 17:02 -
core-ci voted on patch set 5 V +1 09/26/24, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66678
-
Benjamin Franzke uploaded patch set 6
V +109/26/24, 17:21 -
Benjamin Franzke uploaded patch set 7 09/26/24, 17:22
-
core-ci voted on patch set 7 V -1 09/26/24, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66681
-
core-ci voted on patch set 7 V +1 09/26/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66681
-
Andreas Kienast voted on patch set 7 CR +1 V +1 09/27/24, 05:50
-
Benjamin Franzke commented on patch set 7 09/27/24, 07:08
user-settings-manager.ts:18colorSchemeSwitch -
Benjamin Franzke uploaded patch set 8
CR +1V +109/27/24, 07:21 -
Benjamin Franzke commented on patch set 8 09/27/24, 07:21
user-settings-manager.ts:18ReplyDone -
Benjamin Franzke uploaded patch set 9 09/27/24, 07:23
-
core-ci voted on patch set 8 V -1 09/27/24, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66709
-
core-ci voted on patch set 9 V -1 09/27/24, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66710
-
core-ci voted on patch set 9 V +1 09/27/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66710
-
Andreas Kienast voted on patch set 9 CR +1 V +1 09/27/24, 07:57
-
Benjamin Kott voted on patch set 9 CR +2 V +2 09/27/24, 08:02
-
Benjamin Kott merged patch set 10 09/27/24, 08:02