Review main Merged

86345[DOCS] Revise changelogs for v13.2

Sarah McCarthy CR +2 V +2 Hard +165 −163 updated 09/30/24, 09:13

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 913

  1. Sarah McCarthy uploaded patch set 1 09/26/24, 10:19

  2. core-ci voted on patch set 1 V -1 09/26/24, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66658

  3. Chris Müller updated the commit message in patch set 2 09/26/24, 14:25

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  4. core-ci voted on patch set 2 V +1 09/26/24, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66675

  5. Chris Müller commented on patch set 2 CR -1 09/26/24, 15:27

    Sorry, have some remarks.

    Deprecation-103752-ObsoleteGLOBALSTYPO3_CONF_VARSFEaddRootLineFields.rst:15

    Deprecation-103752-ObsoleteGLOBALSTYPO3_CONF_VARSFEaddRootLineFields.rst:45

    Here too.

    Deprecation-103965-DeprecateNamespacedShorthandValidatorUsageInExtbase.rst:21

    Deprecation-103965-DeprecateNamespacedShorthandValidatorUsageInExtbase.rst:35

    Here too.

    Deprecation-103965-DeprecateNamespacedShorthandValidatorUsageInExtbase.rst:42

    Here too.

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:50

    Indentation was previously correct (4 chars).

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:66

    Here too.

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:88

    Here too.

    Important-103915-AutoDBCreationForTCATypeCheck.rst:78

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:22

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:51

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:76

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:80

    Keep indentation with 4 chars.

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:88

    Keep indentation with 4 chars.

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:102

    Really "an" instead of "a"?

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:109

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:161

    Keep indentation with 4 chars.

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:189

    Keep indentation with 4 chars.

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:196

    Keep indentation with 4 chars.

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:210

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:223

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:245

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:248

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:253

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:254

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:281

    Keep indentation with 4 chars.

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:288

    Keep indentation with 4 chars.

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:325

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:326

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:354

    core -> Core

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:355

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:364

    Please also adjust the dashes

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:378

    core team -> Core Team
  6. Chris Müller uploaded patch set 3 CR -1 V +1 09/27/24, 10:05

  7. Chris Müller commented on patch set 3 CR -1 09/27/24, 10:05

    Deprecation-103752-ObsoleteGLOBALSTYPO3_CONF_VARSFEaddRootLineFields.rst:15 Reply

    Done

    Deprecation-103752-ObsoleteGLOBALSTYPO3_CONF_VARSFEaddRootLineFields.rst:45 Reply

    Done

    Deprecation-103965-DeprecateNamespacedShorthandValidatorUsageInExtbase.rst:21 Reply

    Done

    Deprecation-103965-DeprecateNamespacedShorthandValidatorUsageInExtbase.rst:35 Reply

    Done

    Deprecation-103965-DeprecateNamespacedShorthandValidatorUsageInExtbase.rst:42 Reply

    Done

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:50 Reply

    Done

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:66 Reply

    Done

    Deprecation-104108-TableDependantDefinitionOfColumnsOnly.rst:88 Reply

    Done

    Important-103915-AutoDBCreationForTCATypeCheck.rst:78 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:22 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:51 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:76 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:80 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:88 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:109 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:161 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:189 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:196 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:210 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:223 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:245 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:248 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:253 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:254 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:281 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:288 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:325 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:326 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:354 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:355 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:364 Reply

    Done

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:378 Reply

    Done
  8. core-ci voted on patch set 3 V +1 09/27/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66730

  9. Sarah McCarthy uploaded patch set 4 CR -1 V +1 09/27/24, 17:23

  10. core-ci voted on patch set 4 V +1 09/27/24, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66757

  11. Chris Müller commented on patch set 4 CR +1 V +1 09/27/24, 18:10

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:102 Reply

    Done
  12. Garvin Hicking voted on patch set 4 CR +2 V +2 09/30/24, 09:13

  13. Garvin Hicking merged patch set 5 09/30/24, 09:13