Review main Merged

86346[TASK] Streamline array access and constructor definition of SiteWriter

Simon Schaufelberger CR +2 V +2 Easy +10 −10 updated 10/02/24, 18:59

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
    • Thomas Hohn +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Thomas Hohn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2025

  1. Simon Schaufelberger uploaded patch set 1 09/26/24, 10:19

  2. Simon Schaufelberger uploaded patch set 2 09/26/24, 10:20

  3. core-ci voted on patch set 1 V -1 09/26/24, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66659

  4. core-ci voted on patch set 2 V +1 09/26/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66660

  5. Andreas Kienast commented on patch set 2 09/27/24, 10:39

    SiteWriter.php:63

    Why can't this be readonly as well?
  6. Simon Schaufelberger commented on patch set 2 09/27/24, 11:22

    SiteWriter.php:63 Reply

    Maybe someone wants to overwrite it in an extended class for some reason. Who knows...
  7. Andreas Kienast commented on patch set 2 09/27/24, 11:35

    SiteWriter.php:63 Reply

    That's a very unlikely scenario, multiple locations in TYPO3 rely on this being `Environment::getConfigPath() . '/sites'`.
  8. Simon Schaufelberger uploaded patch set 3 V +1 09/27/24, 12:28

  9. Simon Schaufelberger commented on patch set 3 09/27/24, 12:28

    SiteWriter.php:63 Reply

    Done
  10. core-ci voted on patch set 3 V +1 09/27/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66748

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 10/02/24, 12:08

  12. Guido Schmechel voted on patch set 3 CR +1 10/02/24, 13:23

  13. Garvin Hicking commented on patch set 3 CR +1 V +1 10/02/24, 15:16

    Not too happy with the commit title, but don't want to reset votes. Maybe: "Code cleanup in SiteWriter (array access, readonly)" "Streamline array access and constructor definition of SiteWriter" What triggers me a bit is that every commit should "Improve code" ;-)
  14. Thomas Hohn voted on patch set 3 CR +1 10/02/24, 15:35

  15. Simon Schaufelberger updated the commit message in patch set 4 CR +1 V +1 10/02/24, 16:10

  16. Garvin Hicking voted on patch set 4 CR +1 V +1 10/02/24, 16:11

  17. core-ci voted on patch set 4 V -1 10/02/24, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66981

  18. Simon Schaufelberger rebased onto patch set 5 CR +1 V +1 10/02/24, 16:20

  19. core-ci voted on patch set 5 V +1 10/02/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66982

  20. Garvin Hicking voted on patch set 5 CR +1 V +1 10/02/24, 16:36

  21. Chris Müller voted on patch set 5 CR +1 10/02/24, 17:14

  22. Thomas Hohn voted on patch set 5 CR +1 V +1 10/02/24, 17:27

  23. Guido Schmechel voted on patch set 5 CR +1 10/02/24, 18:02

  24. Garvin Hicking voted on patch set 5 CR +2 V +2 10/02/24, 18:59

  25. Garvin Hicking merged patch set 6 10/02/24, 18:59