86346[TASK] Streamline array access and constructor definition of SiteWriter
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Chris Müller +1
- Thomas Hohn +1
- Guido Schmechel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Thomas Hohn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2025
-
Simon Schaufelberger uploaded patch set 1 09/26/24, 10:19
-
Simon Schaufelberger uploaded patch set 2 09/26/24, 10:20
-
core-ci voted on patch set 1 V -1 09/26/24, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66659
-
core-ci voted on patch set 2 V +1 09/26/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66660
-
Andreas Kienast commented on patch set 2 09/27/24, 10:39
-
Simon Schaufelberger commented on patch set 2 09/27/24, 11:22
SiteWriter.php:63ReplyMaybe someone wants to overwrite it in an extended class for some reason. Who knows... -
Andreas Kienast commented on patch set 2 09/27/24, 11:35
SiteWriter.php:63ReplyThat's a very unlikely scenario, multiple locations in TYPO3 rely on this being `Environment::getConfigPath() . '/sites'`. -
Simon Schaufelberger uploaded patch set 3
V +109/27/24, 12:28 -
Simon Schaufelberger commented on patch set 3 09/27/24, 12:28
SiteWriter.php:63ReplyDone -
core-ci voted on patch set 3 V +1 09/27/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66748
-
Christian Kuhn voted on patch set 3 CR +1 V +1 10/02/24, 12:08
-
Guido Schmechel voted on patch set 3 CR +1 10/02/24, 13:23
-
Garvin Hicking commented on patch set 3 CR +1 V +1 10/02/24, 15:16
Not too happy with the commit title, but don't want to reset votes. Maybe: "Code cleanup in SiteWriter (array access, readonly)" "Streamline array access and constructor definition of SiteWriter" What triggers me a bit is that every commit should "Improve code" ;-) -
Thomas Hohn voted on patch set 3 CR +1 10/02/24, 15:35
-
Simon Schaufelberger updated the commit message in patch set 4
CR +1V +110/02/24, 16:10 -
Garvin Hicking voted on patch set 4 CR +1 V +1 10/02/24, 16:11
-
core-ci voted on patch set 4 V -1 10/02/24, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66981
-
Simon Schaufelberger rebased onto patch set 5
CR +1V +110/02/24, 16:20 -
core-ci voted on patch set 5 V +1 10/02/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66982
-
Garvin Hicking voted on patch set 5 CR +1 V +1 10/02/24, 16:36
-
Chris Müller voted on patch set 5 CR +1 10/02/24, 17:14
-
Thomas Hohn voted on patch set 5 CR +1 V +1 10/02/24, 17:27
-
Guido Schmechel voted on patch set 5 CR +1 10/02/24, 18:02
-
Garvin Hicking voted on patch set 5 CR +2 V +2 10/02/24, 18:59
-
Garvin Hicking merged patch set 6 10/02/24, 18:59
SiteWriter.php:63