Review main Merged

86363[BUGFIX] Check existence of `colorScheme` and `theme` when saving user settings

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 09/27/24, 10:55

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 09/27/24, 10:16

  2. core-ci voted on patch set 1 V +1 09/27/24, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66732

  3. Garvin Hicking commented on patch set 1 09/27/24, 10:32

    SetupModuleController.php:206

    What about this one, should we add ?? here too?
  4. Andreas Kienast commented on patch set 1 09/27/24, 10:34

    SetupModuleController.php:206 Reply

    Apparently it's not required for whatever reason. I suspected `BackendUserAuthentication::$uc_default` first, but that doesn't seem to be the trick.
  5. Benjamin Franzke voted on patch set 1 CR +1 V +1 09/27/24, 10:44

  6. Benjamin Kott voted on patch set 1 CR +2 V +2 09/27/24, 10:55

  7. Benjamin Kott merged patch set 2 09/27/24, 10:55