86391[TASK] Add link from the constant editor to the site setting editor
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Jasmina Ließmann +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Jasmina Ließmann +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1724
-
Benjamin Franzke uploaded patch set 1 10/01/24, 10:54
-
Benjamin Franzke uploaded patch set 2 10/01/24, 10:59
-
core-ci voted on patch set 1 V +1 10/01/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66885
-
core-ci voted on patch set 2 V +1 10/01/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66886
-
Torben Hansen updated the commit message in patch set 3
V +110/02/24, 16:43 -
core-ci voted on patch set 3 V +1 10/02/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66983
-
Guido Schmechel voted on patch set 3 CR +1 10/02/24, 21:22
-
Lina Wolf commented on patch set 3 10/12/24, 01:11
When I have a page which uses site sets but the site sets have no site settings the link in the constant editor is still being displayed. When I follow it there is - of course no site set to edit. -
Lina Wolf uploaded patch set 4
CR +1V +110/12/24, 01:14 -
Lina Wolf uploaded patch set 5 10/12/24, 01:16
-
Lina Wolf commented on patch set 5 10/12/24, 01:16
I adjusted the text for the constants editor: As is is commonly used by integrators I would shorten this and formulate it less technically. -
Lina Wolf commented on patch set 5 V -1 10/12/24, 01:17
We need to hide the link to the site settings if there are no site settings -
core-ci voted on patch set 5 V +1 10/12/24, 01:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67627
-
core-ci voted on patch set 4 V +1 10/12/24, 01:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67626
-
Benjamin Franzke uploaded patch set 6
V +112/19/24, 09:36 -
Benjamin Franzke commented on patch set 6 12/19/24, 09:36
Reply
We can not detect that easily within this module and I'd like to avoid putting too much site-set logic into EXT:tstemplate, as this is just a pointer. The site settings module is aware of this case and will show a respective message. -
core-ci voted on patch set 6 V +1 12/19/24, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71438
-
Jasmina Ließmann uploaded patch set 7
V +112/19/24, 18:55 -
Jasmina Ließmann commented on patch set 7 CR +1 V +1 12/19/24, 18:57
Looks good. I updated the language keys slightly to match the existing keys in this file. Hope that's ok. -
core-ci voted on patch set 7 V +1 12/19/24, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71470
-
Stefan Bürk voted on patch set 7 CR +1 V +1 12/23/24, 11:58
-
Benni Mack voted on patch set 7 CR +1 01/02/25, 20:45
-
Benjamin Franzke voted on patch set 7 CR +2 V +2 01/06/25, 06:45
-
Benjamin Franzke merged patch set 8 01/06/25, 06:59