Review main Merged

86397[BUGFIX] Use view transitions for color-scheme and theme changes

Benjamin Franzke CR +2 V +2 Normal +59 −5 updated 10/07/24, 12:24

Commit message

To prevent inconsistent per-element color-transitions during a
color-scheme or theme change, the per-element transitions are now
disabled for the time-frame where the color-scheme or theme attribute
is changed and a view transition is applied now.
This instructs the browser to take a screenshot before and after
the view transition and animate between.

For browsers which do not support view transitions (firefox)
or for users that prefer reduced motion we apply the changes
immediately (with transitions disabled).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1217

  1. Benjamin Franzke uploaded patch set 1 10/01/24, 19:45

  2. Benjamin Franzke uploaded patch set 2 10/01/24, 19:51

  3. core-ci voted on patch set 1 V +1 10/01/24, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66917

  4. core-ci voted on patch set 2 V +1 10/01/24, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66920

  5. Benjamin Franzke updated the commit message in patch set 3 V +1 10/01/24, 21:54

  6. Garvin Hicking commented on patch set 3 10/01/24, 22:02

    I must say I really liked the color transitions, they are so playful and joyful. It was fun to toggle back and forth like that, kind of mesmerizing ... (then again I fall for things like that, but I had to mention it before it goes away without amy ppreciation ;) )
  7. core-ci voted on patch set 3 V +1 10/01/24, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66929

  8. Benjamin Franzke uploaded patch set 4 V +1 10/02/24, 08:51

  9. Benjamin Franzke commented on patch set 4 10/02/24, 08:51

    Reply

    ack, but they were inconsistent, so we need to do something to harmonize that… …but you may want to checkout my latest patchset (in google chrome). I guess you gonna like it ;)
  10. core-ci voted on patch set 4 V +1 10/02/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66956

  11. Garvin Hicking commented on patch set 4 V +1 10/02/24, 12:39

    Reply

    Awwwww! That's basically the same to my teary eyes, thanks. I really appreciate it. (Firefox hopefully will catch up on it)
  12. Andreas Kienast uploaded patch set 5 V +1 10/07/24, 08:40

  13. Andreas Kienast voted on patch set 5 CR +1 V +1 10/07/24, 08:40

  14. core-ci voted on patch set 5 V +1 10/07/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67212

  15. Garvin Hicking voted on patch set 5 CR +1 V +1 10/07/24, 10:36

  16. Benjamin Franzke voted on patch set 5 CR +2 V +2 10/07/24, 12:24

  17. Benjamin Franzke merged patch set 6 10/07/24, 12:24