Review main Merged

86454[BUGFIX] Ensure scrollbar styling is evaluated for each element

Benjamin Kott CR +2 V +2 Easy +5 −1 updated 10/07/24, 15:52

Commit message

The CSS property `--typo3-text-color-base` is changed on a per-element
basis (e.g. with the class mode theme) and therefore the scrollbar
style needs to applied based on the current value of this variable.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benjamin Kott uploaded patch set 1 10/07/24, 15:35

  2. Benjamin Franzke updated the commit message in patch set 2 10/07/24, 15:43

  3. Benjamin Franzke voted on patch set 2 CR +1 V +1 10/07/24, 15:44

  4. core-ci voted on patch set 2 V +1 10/07/24, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67259

  5. Andreas Kienast voted on patch set 2 CR +2 V +2 10/07/24, 15:52

  6. Andreas Kienast merged patch set 3 10/07/24, 15:52