86465[TASK] Resolve all phpstan errors in CorrelationId
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1519
-
Benjamin Franzke uploaded patch set 1 10/08/24, 02:22
-
core-ci voted on patch set 1 V -1 10/08/24, 02:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67295
-
Benjamin Franzke uploaded patch set 2
V -110/08/24, 02:33 -
core-ci voted on patch set 2 V -1 10/08/24, 02:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67297
-
Benjamin Franzke uploaded patch set 3
V -110/08/24, 02:49 -
Benjamin Franzke voted on patch set 3 CR -2 10/08/24, 02:49
-
core-ci voted on patch set 3 V +1 10/08/24, 02:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67300
-
Markus Klein commented on patch set 3 10/08/24, 06:35
I'm not sure whether this is really correct. `aspects` are optional in the string to check and hence will always be set, but may be `''`. The former baseline checked for "non-falsy-string", which is wrong to my understanding. So maybe there was a change in phpstan which corrected this type to "non-empty-string"? will check that. -
Markus Klein commented on patch set 3 CR +1 V +1 10/08/24, 06:40
Reply
Obviously they corrected that type. Good. -
Markus Klein commented on patch set 3 10/08/24, 06:41
CorrelationId.php:63could be simplified now to `$aspects = explode('/', ltrim($matches['aspects'], '/'));` -
Benjamin Franzke commented on patch set 3 10/08/24, 06:43
Reply
yes, they did and because we didn't raise phpstan the error reoccured. -
Benjamin Franzke commented on patch set 3 10/08/24, 07:43
CorrelationId.php:63ReplyNo, would end up as `['']`. (we could use `trimExplode(…, true)` if we'd really want to) -
Stefan Bürk voted on patch set 3 CR +1 V +1 10/08/24, 08:07
-
Benjamin Franzke uploaded patch set 4
CR +1V +110/08/24, 10:29Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 4 V +1 10/08/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67364
-
Stefan Bürk voted on patch set 4 CR +1 V +1 10/08/24, 11:17
-
Christian Kuhn voted on patch set 4 CR +1 V +1 10/08/24, 11:17
-
Stefan Bürk voted on patch set 4 CR +2 V +2 10/08/24, 11:18
-
Stefan Bürk merged patch set 5 10/08/24, 11:18