Review main Merged

86469[BUGFIX] Prevent null pointer exception in BackendController

Oli Bartsch CR +2 V +2 Easy +2 −10 updated 10/08/24, 11:44

Commit message

On processing a redirect parameter for fetching
the backend module it is now properly checked
whether the resolved route is a module route.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Thomas Hohn +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Oli Bartsch uploaded patch set 1 10/08/24, 07:14

  2. Thomas Hohn voted on patch set 1 CR +1 10/08/24, 07:16

  3. Mathias Brodala commented on patch set 1 10/08/24, 07:18

    BackendController.php:398

    Hm, this looks unrelated to the actual fix?
  4. core-ci voted on patch set 1 V +1 10/08/24, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67326

  5. Oli Bartsch commented on patch set 1 10/08/24, 07:26

    BackendController.php:398 Reply

    This method was used instead of the instanceof check. It's not needed anymore as it only handled two non module routes.
  6. Garvin Hicking commented on patch set 1 V +1 10/08/24, 07:26

    Fixes the issue for me, thanks!
  7. Christian Kuhn voted on patch set 1 CR +1 V +1 10/08/24, 08:48

  8. Stefan Bürk voted on patch set 1 CR +1 V +1 10/08/24, 11:34

  9. Stefan Bürk voted on patch set 1 CR +2 V +2 10/08/24, 11:44

  10. Stefan Bürk merged patch set 2 10/08/24, 11:44