Review main Merged

86553[BUGFIX] Reference correct field in CacheLifeTimeCalculator

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 10/11/24, 07:20

Commit message

TCA configuration `ctrl/enablecolumns/starttime|endtime` may use a
different field name than `starttime` or `endtime`, which may fail then
in `CacheLifeTimeCalculator`. This commit uses the previously correctly
resolved field name when calculating the cache timeout.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 10/11/24, 05:51

  2. Benjamin Franzke voted on patch set 1 CR +1 10/11/24, 05:56

  3. core-ci voted on patch set 1 V +1 10/11/24, 05:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67552

  4. Benjamin Franzke voted on patch set 1 V +1 10/11/24, 06:33

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 10/11/24, 07:13

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 10/11/24, 07:20

  7. Andreas Kienast merged patch set 2 10/11/24, 07:20