Review main Merged

86578[DOCS] Revise changelogs for v13.4

Lina Wolf CR +2 V +2 Normal +74 −66 updated 10/14/24, 12:40

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sandra Erbel +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sandra Erbel +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1621

  1. Lina Wolf uploaded patch set 1 10/13/24, 17:24

  2. core-ci voted on patch set 1 V +1 10/13/24, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67715

  3. Mathias Brodala commented on patch set 1 10/14/24, 06:53

    Deprecation-105171-INCLUDE_TYPOSCRIPTTypoScriptSyntax.rst:80

    This is a different approach. The current docs show how you can keep including *.ts files without renaming them. Of course it is debatable why you cannot simply rename all files, but still …

    Deprecation-105171-INCLUDE_TYPOSCRIPTTypoScriptSyntax.rst:104

    Can we rephrase the "... not allow ... not allowing ..." which sounds awkward while we're at it?

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:6

    The current one is a Composer package name. So either add the :composer: annotation, or rename this to "Doctrine DBAL".

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:14

    "did provide" IMO

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:41

    The wording is "Composer Mode" AFAIK: https://extensions.typo3.org/help/composer-support
  4. Stefan Froemken commented on patch set 1 CR -1 10/14/24, 07:13

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:49

    Duplicate "to". See line above
  5. Lina Wolf commented on patch set 1 10/14/24, 07:16

    Deprecation-105171-INCLUDE_TYPOSCRIPTTypoScriptSyntax.rst:80 Reply

    I talked about this with lolli. Using the .ts file ending is not possible with the @import syntax
  6. Mathias Brodala commented on patch set 1 10/14/24, 07:25

    Deprecation-105171-INCLUDE_TYPOSCRIPTTypoScriptSyntax.rst:80 Reply

    Ah OK, didn't look into the source once more for this. In this case ignore my comments on this topic. :-)
  7. Lina Wolf commented on patch set 2 CR -1 V +1 10/14/24, 07:29

    Published edit on patch set 1.
  8. Lina Wolf commented on patch set 3 10/14/24, 07:31

    Published edit on patch set 2.
  9. Lina Wolf commented on patch set 4 10/14/24, 07:32

    Published edit on patch set 3.
  10. Lina Wolf commented on patch set 4 10/14/24, 07:32

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:6 Reply

    Done

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:14 Reply

    Done

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:41 Reply

    Done

    Deprecation-105279-ReplaceTYPO3EnumTypeWithDoctrinedbalEnumType.rst:49 Reply

    Done
  11. Lina Wolf commented on patch set 5 10/14/24, 07:35

    Published edit on patch set 4.
  12. Lina Wolf commented on patch set 5 10/14/24, 07:36

    Deprecation-105171-INCLUDE_TYPOSCRIPTTypoScriptSyntax.rst:104 Reply

    Done
  13. core-ci voted on patch set 3 V +1 10/14/24, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67742

  14. core-ci voted on patch set 4 V +1 10/14/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67743

  15. core-ci voted on patch set 2 V +1 10/14/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67741

  16. core-ci voted on patch set 5 V +1 10/14/24, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67745

  17. Garvin Hicking voted on patch set 5 CR +1 V +1 10/14/24, 08:50

  18. Sandra Erbel voted on patch set 5 CR +1 V +1 10/14/24, 09:27

  19. Stefan Froemken voted on patch set 5 CR +1 V +1 10/14/24, 10:31

  20. Garvin Hicking voted on patch set 5 CR +2 V +2 10/14/24, 12:40

  21. Garvin Hicking merged patch set 6 10/14/24, 12:40