Review main Merged

86580[BUGFIX] Allow nullable link fields to be transformed

Benni Mack CR +2 V +2 Normal +89 −2 updated 10/14/24, 17:18

Commit message

If a nullable link field is transformed, and the value
is explicitly null, this should be transformed properly
to also return null.

Previously this resulted in a PHP error due to
missing type casting.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1115

  1. Benni Mack uploaded patch set 1 10/14/24, 06:46

  2. core-ci voted on patch set 1 V -1 10/14/24, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67738

  3. Oli Bartsch uploaded patch set 2 V -1 10/14/24, 14:45

  4. core-ci voted on patch set 2 V +1 10/14/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67768

  5. Benni Mack updated the commit message in patch set 3 V +1 10/14/24, 15:14

  6. core-ci voted on patch set 3 V +1 10/14/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67771

  7. André Buchmann commented on patch set 3 10/14/24, 15:49

    The nested sentence is hard to read. Maybe like this: If a nullable link field is transformed, and the value is explicitly null, this should be transformed properly.
  8. Benni Mack updated the commit message in patch set 4 V +1 10/14/24, 16:12

  9. Benni Mack commented on patch set 4 10/14/24, 16:12

    Reply

    Done
  10. core-ci voted on patch set 4 V +1 10/14/24, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67775

  11. Oli Bartsch voted on patch set 4 CR +1 V +1 10/14/24, 16:24

  12. Stefan Bürk voted on patch set 4 CR +1 10/14/24, 16:43

  13. Nikita Hovratov voted on patch set 4 CR +1 V +1 10/14/24, 16:50

  14. Oli Bartsch voted on patch set 4 CR +2 V +2 10/14/24, 17:18

  15. Oli Bartsch merged patch set 5 10/14/24, 17:18