Review main Abandoned

86583[WIP][BUGFIX] Avoid re-paints/layouts in tree drag&drop

Andreas Kienast CR 0 V 0 Normal +41 −20 updated 11/21/25, 07:42

Commit message

Safari sucks...

Attempts:

* Use event delegation for drag events where possible
* Unstate coordinates in tooltip to avoid re-renderings

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 4

Review log 914

  1. Andreas Kienast uploaded patch set 1 10/14/24, 13:14

  2. core-ci voted on patch set 1 V -1 10/14/24, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67753

  3. Andreas Kienast uploaded patch set 2 V -1 10/14/24, 13:44

  4. core-ci voted on patch set 2 V +1 10/14/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67758

  5. Andreas Kienast uploaded patch set 3 V +1 10/14/24, 20:58

  6. core-ci voted on patch set 3 V +1 10/14/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67779

  7. Andreas Kienast uploaded patch set 4 V +1 10/15/24, 05:35

  8. core-ci voted on patch set 4 V +1 10/15/24, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67792

  9. Benjamin Franzke commented on patch set 4 03/05/25, 13:55

    _tree.scss:103

    Since we merged this in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88366 I guess we can abandon this one?
  10. Andreas Kienast commented on patch set 4 03/06/25, 07:11

    _tree.scss:103 Reply Unresolved

    This patch aimed to improve the performance of the tree in Safari even more as the current state is still not satisfying. However, I'm in the dark here and no clue if the event stuff is really the issue here.
  11. Benni Mack marked it work in progress 03/22/25, 14:15

  12. Andreas Kienast uploaded patch set 5 V +1 03/25/25, 14:34

  13. core-ci voted on patch set 5 V +1 03/25/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76264

  14. Andreas Kienast abandoned the change 11/21/25, 07:42