86606[TASK] Remove unneeded checks for rendering the record list search box
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1825
-
TYPO3com uploaded patch set 1 10/15/24, 12:02
-
core-ci voted on patch set 1 V +1 10/15/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67837
-
Garvin Hicking updated the commit message in patch set 2
V +110/15/24, 14:45 -
Garvin Hicking updated the commit message in patch set 3 10/15/24, 14:45
-
core-ci voted on patch set 2 V +1 10/15/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67843
-
core-ci voted on patch set 3 V +1 10/15/24, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67844
-
Stefan Rumzucker commented on patch set 3 03/17/25, 10:45
Any updates on this issue? Would be a small but valuable change for using filtered record lists. -
Garvin Hicking commented on patch set 3 03/17/25, 11:44
Reply
@akienast@scripting-base.de any thoughts maybe, you did some work in this area past weeeks? -
Andreas Kienast commented on patch set 3 V -1 03/17/25, 15:38
I don't see a benefit in this patch. Yes, you will get a search box — however, you're still stuck in the single table view, which will display nothing nonetheless. -
Stefan Rumzucker commented on patch set 3 03/18/25, 08:05
Reply
Sorry, but did you read the ticket description? I tried to explain the issue as understandable as possible. What's the benefit of deliberately not showing the user a possibility to search and filter items of sub pages? -
Andreas Kienast commented on patch set 3 03/18/25, 08:36
Reply
AFAICS this can only be triggered if you are in a single table view (is that what you mean with "table filter"?) and modify the ID in the URL? -
Stefan Rumzucker commented on patch set 3 03/18/25, 08:52
Reply
If "single table view" is the common definition for using URLs like `/typo3/module/web/list?id=1&table=sys_category`, then yes. When using such backend links, selecting pages/folders without direct child items of this type, it's simply not possible to adjust the "search level". -
Andreas Kienast commented on patch set 3 CR +1 V +1 03/18/25, 08:55
Reply
Thanks. I indeed didn't have the search level in mind. The patch is fine for me. -
Andreas Kienast updated the commit message in patch set 4
CR +1V +103/18/25, 08:55 -
Andreas Kienast voted on patch set 4 CR +1 V +1 03/18/25, 08:55
-
core-ci voted on patch set 4 V -1 03/18/25, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75766
-
Garvin Hicking voted on patch set 4 CR +1 V +1 03/18/25, 10:05
-
Garvin Hicking updated the commit message in patch set 5
CR +1V +103/18/25, 10:07 -
Garvin Hicking voted on patch set 5 CR +1 V +1 03/18/25, 10:09
-
core-ci voted on patch set 5 V -1 03/18/25, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75769
-
Garvin Hicking rebased onto patch set 6
CR +1V +103/18/25, 11:12 -
core-ci voted on patch set 6 V +1 03/18/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75772
-
Garvin Hicking voted on patch set 6 CR +1 V +1 03/18/25, 11:58
-
Georg Ringer voted on patch set 6 CR +2 V +2 03/24/25, 20:53
-
Georg Ringer merged patch set 7 03/24/25, 20:53