86607[BUGFIX] Skip non-existant content elements in widget
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1317
-
André Buchmann uploaded patch set 1 10/15/24, 14:06
-
core-ci voted on patch set 1 V +1 10/15/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67841
-
Garvin Hicking commented on patch set 1 CR +1 V +1 10/15/24, 14:53
Good one! Note that 13.4 is not branched yet; if this should get merged before, "main" will suffice. (I would prefer a 'nullable' return here instead of returning '0' but that would technically be a breaking change now, so 'return 0' is an understandable compromise) -
Garvin Hicking updated the commit message in patch set 2
CR +1V +110/15/24, 19:57 -
core-ci voted on patch set 2 V +1 10/15/24, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67851
-
Garvin Hicking commented on patch set 2 10/16/24, 11:03
Reply
I was hinted at the affected method being private, so we should be able to use `?int` here and a null return, maybe you can try to change this? -
Andreas Kienast commented on patch set 2 10/16/24, 11:05
LatestChangedPagesWidget.php:229This should add `TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction` again.LatestChangedPagesWidget.php:236This should add `TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction` again. -
Andreas Kienast uploaded patch set 3
V +110/16/24, 11:10 -
Andreas Kienast commented on patch set 3 10/16/24, 11:11
Reply
DoneLatestChangedPagesWidget.php:229ReplyDoneLatestChangedPagesWidget.php:236ReplyDone -
core-ci voted on patch set 3 V +1 10/16/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67879
-
Garvin Hicking voted on patch set 3 CR +1 V +1 10/16/24, 11:43
-
André Buchmann voted on patch set 3 CR +1 V +1 10/16/24, 17:32
-
Andreas Kienast updated the commit message in patch set 4
CR +1V +110/17/24, 07:58 -
Garvin Hicking voted on patch set 4 CR +1 V +1 10/17/24, 07:59
-
core-ci voted on patch set 4 V +1 10/17/24, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67909
-
Andreas Kienast voted on patch set 4 CR +2 V +2 10/17/24, 08:08
-
Andreas Kienast merged patch set 5 10/17/24, 08:08