Review main Merged

86634[DOCS] Add details for CSS-prefixing in EXT:rte_ckeditor

Garvin Hicking CR +2 V +2 Easy +33 −5 updated 10/18/24, 13:25

Commit message

The current automatism of auto-prefixing might not be
easily understandable, so the process is now described
more clearly, with an example.

Also `:root` is mentioned to apply additional reset
possibilites.

A note that the CSS file is cached (for now) and has
no automatic cache busting is added, too.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Andreas Nedbal +1
    • Sebastian Klein +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Andreas Nedbal +1
    • Sebastian Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Garvin Hicking uploaded patch set 1 10/17/24, 07:37

  2. core-ci voted on patch set 1 V +1 10/17/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67907

  3. Sebastian Klein commented on patch set 1 10/17/24, 10:13

    Reference.rst:77

    Proposal: mention and demonstrate the possibility to set more than one stylesheet, e.g. "defines the location of one or more CSS files for the editor and the styles that can be applied."

    Reference.rst:82

    Proposal (see above): second line with - "EXT:my_sitepackage/Resources/Public/Css/project-rte.css"

    Reference.rst:111

    We currently have at least - "EXT:my_site/…", - "EXT:sitepackage/…", - "EXT:my_sitepackage/…", and - "EXT:my_site_package/…" used for examples in the Core. Would be good to use one of these extension names (and maybe agree on one example extension name later).
  4. Garvin Hicking commented on patch set 2 V +1 10/17/24, 10:23

    Published edit on patch set 1.
  5. Garvin Hicking commented on patch set 1 10/17/24, 10:24

    Reference.rst:77 Reply

    Yes, good idea. Done. Also rephrased it a bit.

    Reference.rst:82 Reply

    Done

    Reference.rst:111 Reply

    Ack. At least it's unified in this document, but this is a cleanup that needs to be done (with its own patch though). This will be a tedious effort though...
  6. core-ci voted on patch set 2 V +1 10/17/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67914

  7. Sebastian Klein commented on patch set 2 10/17/24, 11:21

    Reference.rst:77

    Minor typo in "containing"
  8. Garvin Hicking commented on patch set 3 V +1 10/17/24, 12:42

    Published edit on patch set 2.
  9. Garvin Hicking commented on patch set 3 10/17/24, 12:42

    Reference.rst:77 Reply

    Done
  10. core-ci voted on patch set 3 V +1 10/17/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67918

  11. Sebastian Klein voted on patch set 3 CR +1 V +1 10/17/24, 13:09

  12. Andreas Nedbal voted on patch set 3 CR +1 V +1 10/18/24, 09:20

  13. Garvin Hicking voted on patch set 3 CR +2 V +2 10/18/24, 13:25

  14. Garvin Hicking merged patch set 4 10/18/24, 13:25