Review main Merged

86639[DOCS] Embed System Notes Video Tutorial

TYPO3com CR +2 V +2 Easy +8 −0 updated 11/04/24, 13:47

Commit message

Add the sys_note video tutorial to the "For Editors" page of
the documentation.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1117

  1. TYPO3com uploaded patch set 1 10/17/24, 12:13

  2. core-ci voted on patch set 1 V +1 10/17/24, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67916

  3. Chris Müller updated the commit message in patch set 2 V +1 10/17/24, 13:36

  4. Chris Müller commented on patch set 2 10/17/24, 13:36

    I would rather move this to the Introduction chapter? Other opinions?
  5. Chris Müller updated the commit message in patch set 3 10/17/24, 13:37

  6. core-ci voted on patch set 2 V -1 10/17/24, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67922

  7. core-ci voted on patch set 3 V -1 10/17/24, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67924

  8. core-ci voted on patch set 3 V +1 10/17/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67924

  9. Andreas Kienast commented on patch set 3 10/17/24, 14:39

    Reply

    Not sure. Based on the video's content it also fits into "For Editors", and putting the same videos in two categories isn't helpful. IMO, it's fine here.
  10. Andreas Kienast voted on patch set 3 CR +1 V +1 10/18/24, 12:02

  11. Benjamin Franzke uploaded patch set 4 CR +1 V +1 11/04/24, 10:52

  12. Benjamin Franzke commented on patch set 4 11/04/24, 10:52

    Reply

    Moved into "For Editors" and added a description and a headline for the video.
  13. core-ci voted on patch set 4 V +1 11/04/24, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69029

  14. Benjamin Franzke voted on patch set 4 CR +1 V +1 11/04/24, 11:11

  15. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/04/24, 11:12

  16. Andreas Kienast voted on patch set 4 CR +2 V +2 11/04/24, 13:40

  17. Andreas Kienast merged patch set 5 11/04/24, 13:47