86642[TASK] Move record list specific actions from AjaxDataHandler
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/ajax-data-handler.ts4+1 −202
- Build/Sources/TypeScript/backend/recordlist.ts6+171 −19
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+0 −4
- typo3/sysext/backend/Resources/Public/JavaScript/ajax-data-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/recordlist.js+1 −1
Review log 3546
Show 1621 earlier messages
-
Andreas Kienast uploaded patch set 1 10/17/24, 13:38
-
core-ci voted on patch set 1 V -1 10/17/24, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67925
-
Benni Mack commented on patch set 1 01/31/25, 18:37
-
Daniel Windloff commented on patch set 1 02/02/25, 11:57
RecordListController.php:231I suggest toggleRecordVisibilityActionRecordListController.php:238$action hasn't been checked in isset.RecordListController.php:245Check for $this->tcaSchemaFactory->has($table); with exception is missing. -
Andreas Kienast commented on patch set 1 02/03/25, 14:44
RecordListController.php:231ReplyAcknowledgedRecordListController.php:238ReplyAcknowledgedRecordListController.php:238ReplyAcknowledgedRecordListController.php:245ReplyAcknowledged -
Andreas Kienast uploaded patch set 2
V -102/03/25, 15:23 -
core-ci voted on patch set 2 V +1 02/03/25, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73416
-
Andreas Kienast uploaded patch set 3
V +102/11/25, 15:01 -
core-ci voted on patch set 3 V +1 02/11/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73995
-
Georg Ringer commented on patch set 3 02/12/25, 09:59
RecordListController.php:272why not using BackendUtility::getRecord?RecordListController.php:285I guess this could fail if the record has not been found? -
Andreas Kienast commented on patch set 3 02/12/25, 10:25
RecordListController.php:272ReplyI have no strong opinion here.RecordListController.php:285ReplyHonestly, at this point I'd expect DataHandler to fail before. This should be checked before, then. -
Andreas Kienast uploaded patch set 4
V +102/12/25, 15:59 -
Andreas Kienast commented on patch set 4 02/12/25, 16:00
RecordListController.php:272ReplyDone -
Andreas Kienast uploaded patch set 5 02/12/25, 16:00
-
Andreas Kienast uploaded patch set 6 02/12/25, 16:05
-
Andreas Kienast commented on patch set 5 02/12/25, 16:05
RecordListController.php:285ReplyDone -
core-ci voted on patch set 4 V +1 02/12/25, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74046
-
core-ci voted on patch set 6 V +1 02/12/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74048
-
Andreas Kienast uploaded patch set 7
V +102/13/25, 07:23 -
Andreas Kienast commented on patch set 7 02/13/25, 07:24
I've extracted the record toggle change with its dedicated controller action into a new patch, as it's not directly related to the breaking change. -
Andreas Kienast uploaded patch set 8 02/13/25, 07:26
-
core-ci voted on patch set 7 V +1 02/13/25, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74099
-
core-ci voted on patch set 8 V +1 02/13/25, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74101
-
Anja Leichsenring voted on patch set 8 CR +1 V +1 02/13/25, 10:31
-
Andreas Kienast uploaded patch set 9
CR +1V +102/18/25, 15:05 -
Andreas Kienast commented on patch set 9 02/18/25, 15:07
After discussing this patch with @ben@bnf.dev, we came to the conclusion it is not a breaking change. Developers are advised to use the `f:be.tableList` view helper, which is still functional. -
core-ci voted on patch set 9 V +1 02/18/25, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74327
-
Benjamin Franzke commented on patch set 9 02/18/25, 15:25
ajax-data-handler.ts:37Method is now unused and can be removed -
Benjamin Franzke uploaded patch set 10
V +102/18/25, 15:26 -
Benjamin Franzke commented on patch set 10 02/18/25, 15:26
ajax-data-handler.ts:37ReplyDone -
core-ci voted on patch set 10 V -1 02/18/25, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74330
-
Andreas Kienast uploaded patch set 11
V -102/18/25, 15:37 -
Andreas Kienast commented on patch set 11 02/18/25, 15:37
ajax-data-handler.ts:37ReplyNice catch, I also rebuilt the JavaScript file 😄. -
core-ci voted on patch set 11 V +1 02/18/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74331
-
Benjamin Franzke commented on patch set 11 CR +1 V +1 02/18/25, 16:18
I'd also be fine with 13.4 here, but that's up to you.ajax-data-handler.ts:37ReplyFor some reason `npm run build-js` didn't produce changes for me 😕 Anyway, thx. -
Andreas Nedbal voted on patch set 11 CR +1 V +1 02/19/25, 10:31
-
Simon Schaufelberger commented on patch set 11 02/19/25, 10:35
recordlist.ts:257what if there are errors? Wouldn't it be good to show a notification with the error message?recordlist.ts:343why is there no error handling check like on the toggle? -
Andreas Kienast commented on patch set 11 02/19/25, 10:40
recordlist.ts:257ReplyThat would probably be good, but not scope of this patch. There's a follow up patch that reworks record toggling. -
Simon Schaufelberger commented on patch set 11 CR +1 V +1 02/19/25, 10:44
recordlist.ts:343ReplyAcknowledged -
Andreas Kienast commented on patch set 11 02/19/25, 10:44
recordlist.ts:343ReplyI agree this is missing for the special case that "has errors" is true. IMO this needs rework in `SimpleDataHandlerController` anyway, sending "OK" (Status 200) does not make sense. -
Andreas Kienast uploaded patch set 12
CR +1V +102/19/25, 10:45 -
Andreas Nedbal voted on patch set 12 CR +1 V +1 02/19/25, 10:47
-
Simon Schaufelberger commented on patch set 12 CR +1 V +1 02/19/25, 10:49
recordlist.ts:343ReplyDone -
core-ci voted on patch set 12 V +1 02/19/25, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74369
-
Andreas Kienast voted on patch set 12 CR +2 V +2 02/19/25, 10:54
-
Andreas Kienast merged patch set 13 02/19/25, 10:54
RecordListController.php:238