86659[TASK] Update repository.ts DOM TEXT Interpreted as HTML
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 57
-
TYPO3com uploaded patch set 1 10/19/24, 10:52
-
core-ci voted on patch set 1 V -1 10/19/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68225
-
Shivam Tiwari commented on patch set 1 CR +1 V +1 10/21/24, 03:25
Hii Can Some one Review This Changes Regards -
Andreas Kienast commented on patch set 1 CR -1 10/21/24, 05:44
Hello Shivam, thank you for contributing to TYPO3 and making the product better. Unfortunately, these patches won't go in as-is as you've modified the TypeScript sources only, but didn't rebuild the JavaScript code. This is a must! Also, please refrain from adding random contributors as reviewers to your patches. Kind regards Andreas -
Andreas Kienast commented on patch set 1 V -1 10/21/24, 05:56
This won't work as we inject HTML on purpose here. -
Andreas Kienast abandoned the change 10/21/24, 06:44
-
Shivam Tiwari commented on patch set 1 10/21/24, 08:56
Hii Thanks For Responding As I am New to Here Typo3 As Contributor can I just get the steps how to rebuild JavaScript Code and How Patch Reviewers Can be Assigned? Thanks & RegardsReply Unresolved
Hii Thanks For Responding As I am New to Here Typo3 As Contributor can I just get the steps how to rebuild JavaScript Code and How Patch Reviewers Can be Assigned? Thanks & Regards