86662[FEATURE] Display values in BE-forms like they get stored after `FormEngineValidation`-processing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 57
-
Ayke Halder uploaded patch set 1 10/19/24, 21:11
-
core-ci voted on patch set 1 V +1 10/19/24, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68237
-
Ayke Halder rebased onto patch set 2
V +110/20/24, 12:59 -
core-ci voted on patch set 2 V +1 10/20/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68261
-
Benjamin Franzke commented on patch set 2 CR -1 10/28/24, 08:08
form-engine-validation.ts:140We should explicitly check of an empty string and only set an empty string in that case, otherwise we would be resetting values when values are invalid because of min/max boundaries. Also we should probably do this in the `invalid` event -
Ayke Halder commented on patch set 2 10/29/24, 14:08
This change is ready for review.form-engine-validation.ts:140Reply UnresolvedJust as reference before closing this: https://developer.mozilla.org/en-US/docs/Web/API/ValidityState/badInput We can further refine the check by checking for `humanReadableField.validity?.badInput? === true` -
Ayke Halder abandoned the change 10/29/24, 14:09
Closed in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822
form-engine-validation.ts:137Unresolved