Review main Merged

86672[BUGFIX] Make popovers context aware

Andreas Kienast CR +2 V +2 Normal +205 −24 updated 10/22/24, 12:05

Commit message

We are dropping the Bootstrap CSS definitions for
all popovers to have more control about the styling of
the popover elements. From now on we are shipping
custom css adapted to our needs. The new popover
element styling is context aware and adapts to
light and dark color schemes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Andreas Kienast uploaded patch set 1 10/21/24, 10:47

  2. Andreas Kienast commented on patch set 1 CR -1 10/21/24, 10:48

    accidentally changed popover.js
  3. Andreas Kienast uploaded patch set 2 CR -1 10/21/24, 10:49

  4. core-ci voted on patch set 1 V -1 10/21/24, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68296

  5. core-ci voted on patch set 2 V +1 10/21/24, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68297

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 10/21/24, 14:28

  7. Andreas Kienast uploaded patch set 3 CR +1 V +1 10/22/24, 06:48

  8. Andreas Kienast uploaded patch set 4 10/22/24, 06:52

  9. core-ci voted on patch set 3 V +1 10/22/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68352

  10. core-ci voted on patch set 4 V +1 10/22/24, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68353

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 10/22/24, 07:24

  12. Oli Bartsch voted on patch set 4 CR +1 V +1 10/22/24, 12:02

  13. Andreas Kienast voted on patch set 4 CR +2 V +2 10/22/24, 12:05

  14. Andreas Kienast merged patch set 5 10/22/24, 12:05