86702[BUGFIX] Handle invalid pageTitleProviders definitions
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Markus Klein +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2025
-
Lina Wolf uploaded patch set 1 10/23/24, 07:23
-
core-ci voted on patch set 1 V -1 10/23/24, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68428
-
Lina Wolf uploaded patch set 2
V -110/23/24, 07:32 -
core-ci voted on patch set 2 V +1 10/23/24, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68430
-
Oli Bartsch commented on patch set 2 10/24/24, 06:34
-
Lina Wolf commented on patch set 2 10/24/24, 06:37
PageTitleProviderManager.php:57ReplyWe probably could but that is not part of this change. It has been there before -
Lina Wolf commented on patch set 2 10/24/24, 06:37
PageTitleProviderManager.php:57ReplyAcknowledged -
Garvin Hicking commented on patch set 2 11/08/24, 09:10
PageTitleProviderManager.php:57ReplyI also think that this would be the more legible solution: ``` if (is_subclass_of($configuration['provider'], PageTitleProviderInterface::class)) { ``` is_subclass_of() can take a string as input but also NULL (mixed) and will not fail, unlike class_exists(). And it will return false when passing a NULL input. -
Markus Klein commented on patch set 2 11/08/24, 09:35
PageTitleProviderManager.php:57ReplyI'd skip the class_exists too. is_subclass_of does autoloading and basically includes the class_exists check -
Oli Bartsch commented on patch set 2 11/08/24, 09:46
PageTitleProviderManager.php:57ReplyJust make sure to use `is_subclass_of($configuration['provider'] ?? null, PageTitleProviderInterface::class)` to prevent undefined array key warnings. -
Lina Wolf uploaded patch set 3
V +111/08/24, 10:48 -
Lina Wolf commented on patch set 3 11/08/24, 10:53
PageTitleProviderManager.php:57ReplyDone -
core-ci voted on patch set 3 V +1 11/08/24, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69227
-
Garvin Hicking commented on patch set 3 CR +1 V +1 11/08/24, 11:02
Looks good to me and seems to work; sadly not covered by tests, and adding tests to the manager doesn't look too straight forward that would rectify the effort for this specific patch. -
Oli Bartsch commented on patch set 3 11/08/24, 11:11
Shouldn't we backport this to v12 as well? -
Garvin Hicking commented on patch set 3 11/08/24, 11:18
Reply
I'm often not sure what classifies as 'priority bugfix'. I think having this in v12 would be an improvement, yes. -
Markus Klein commented on patch set 3 11/08/24, 12:48
Reply
My approach: If it was important enough to be reported for v12, I target v12. It also shows appreciation to the reporter. Benni can still deny it. -
Markus Klein updated the commit message in patch set 4
CR +1V +111/08/24, 12:48 -
Markus Klein updated the commit message in patch set 5 11/08/24, 12:51
-
Markus Klein voted on patch set 5 CR +1 V +1 11/08/24, 12:51
-
core-ci voted on patch set 4 V +1 11/08/24, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69230
-
core-ci voted on patch set 5 V +1 11/08/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69231
-
Garvin Hicking voted on patch set 5 CR +1 V +1 11/08/24, 13:36
-
Oli Bartsch voted on patch set 5 CR +2 V +2 11/08/24, 13:37
-
Oli Bartsch merged patch set 6 11/08/24, 13:37
PageTitleProviderManager.php:57