Review main Merged

86752[BUGFIX] Create shorter runtime cache identifier in `GreedyDatabaseBackend`

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 10/24/24, 11:32

Commit message

The runtime cache identifier created by
`GreedyDatabaseBackend->createRuntimeCacheIdentifier()` may easily
exceed the allowed 250 characters, as defined in the regex stored in
`FrontendInterface::PATTERN_ENTRYIDENTIFIER`.

To circumvent this, all variable arguments are now hashed via `xxh3`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 10/24/24, 10:10

  2. Benni Mack voted on patch set 1 CR +1 10/24/24, 10:11

  3. core-ci voted on patch set 1 V +1 10/24/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68526

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 10/24/24, 10:28

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 10/24/24, 11:23

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 10/24/24, 11:24

  7. Christian Kuhn merged patch set 2 10/24/24, 11:32