Review main Merged

86813[BUGFIX] Fix template clone for database charset wizard

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 10/29/24, 20:06

Commit message

The template wizard has not been cloned properly, as the `cloneNode()`
call was made on the target element instead of the source element
due to improper usage of parenthesis.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Benjamin Franzke uploaded patch set 1 10/28/24, 17:11

  2. core-ci voted on patch set 1 V +1 10/28/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68731

  3. Andreas Kienast commented on patch set 1 CR +1 V +1 10/29/24, 07:02

    Nasty
  4. Andreas Kienast commented on patch set 1 10/29/24, 07:03

    Is there a ESlint rule that catches such stuff? Some kind of a "non-assignment" rule?
  5. Benjamin Franzke commented on patch set 1 10/29/24, 17:44

    Reply

  6. Benni Mack voted on patch set 1 CR +1 V +1 10/29/24, 18:26

  7. Benjamin Franzke voted on patch set 1 CR +2 V +2 10/29/24, 20:05

  8. Benjamin Franzke merged patch set 2 10/29/24, 20:06