Review main Merged

86838[TASK] Disable unapplied TS-highlighting for unknown-variables in CodeMirror

Ayke Halder CR +2 V +2 Easy +2 −2 updated 11/15/24, 20:19

Commit message

This removes any TS-highlighting for unknown-variables in CodeMirror.
This does not visually change the styling of unknown-variables.

Before a style `other` was defined to be applied to unknown-variables,
but the style `other` does not exist.
Thereby no style was applied and the unknown-variables were already
styled in default-text-style 'black'.

Before a warning was shown in browser's dev console:
`Unknown highlighting tag other`

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Ayke Halder uploaded patch set 1 10/30/24, 15:20

  2. core-ci voted on patch set 1 V +1 10/30/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68854

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/15/24, 09:34

  4. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 11/15/24, 13:22

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 11/15/24, 13:22

  6. core-ci voted on patch set 2 V +1 11/15/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69483

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 11/15/24, 17:12

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 11/15/24, 20:19

  9. Oli Bartsch merged patch set 3 11/15/24, 20:19