Review main Merged

86887[BUGFIX] Early return if no rootline provided in SysTemplateRepository

Georg Ringer CR +2 V +2 Easy +14 −0 updated 11/07/24, 09:52

Commit message

Avoid an invalid SQL syntax by using an early return if no
rootline is provided to the method `getSysTemplateRowsByRootline`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Georg Ringer uploaded patch set 1 11/05/24, 16:53

  2. Georg Ringer commented on patch set 1 11/05/24, 16:53

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/05/24, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69111

  4. Oli Bartsch uploaded patch set 2 V +1 11/05/24, 17:20

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 11/05/24, 17:21

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 11/05/24, 17:27

  7. core-ci voted on patch set 2 V +1 11/05/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69116

  8. Andreas Kienast voted on patch set 2 CR +1 11/06/24, 11:52

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 11/07/24, 09:52

  10. Oli Bartsch merged patch set 3 11/07/24, 09:52