Review 12.4 Merged

86890[BUGFIX] Generate correct overlay icon when hiding record in record list

Andreas Kienast CR +2 V +2 Easy +18 −11 updated 11/06/24, 06:58

Commit message

When hiding a record in the record list, a placeholder icon with a
hard-coded overlay `overlay-hidden` was generated.
This is the default overlay, unless an event listener for the event
`ModifyRecordOverlayIconIdentifierEvent` is implemented that may
override this.
The overridden icon is correctly shown when initially rendering the
records, but not when visible icons get hidden.

This patch now always generates a dummy icon in a forced hidden state to
get the overlay icon identier, which is then used in the toggle action.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast uploaded patch set 1 11/06/24, 06:49

  2. core-ci voted on patch set 1 V +1 11/06/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69134

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 11/06/24, 06:58

  4. Andreas Kienast merged patch set 2 11/06/24, 06:58