Review 12.4 Merged

86922[BUGFIX] Handle invalid pageTitleProviders definitions

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 11/08/24, 14:06

Commit message

If the provider for a page title is not a valid class for some reason
the core code must silently skip that.

The call to class_exists() is removed in favor of the existing
call to is_subclass_of().
is_subclass_of() can take a string as input but also NULL (mixed) and will not fail, unlike class_exists(). And it will return false when
being passed a NULL input.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Oli Bartsch uploaded patch set 1 11/08/24, 13:37

  2. core-ci voted on patch set 1 V -1 11/08/24, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69233

  3. core-ci voted on patch set 1 V +1 11/08/24, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69233

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 11/08/24, 14:06

  5. Oli Bartsch merged patch set 2 11/08/24, 14:06