Review 12.4 Merged

86938[BUGFIX] Display correct method for callable event listeners

Oli Bartsch CR +2 V +2 Easy +7 −1 updated 11/12/24, 08:11

Commit message

In case an event listener is not registered
with a `method`, it's treated as callable
by the ListenerProvider and therefore its
`__invoke()` method is called.

For such cases, the configuration module
displayed `method =`, which is misleading
as this might look like the listener
registration is broken.

Therefore, the configuration module now
displays `method = __invoke` in case a
listener is used as callable (does not
define a  dedicated method in the
registration).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 11/12/24, 07:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/12/24, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69348

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 11/12/24, 08:11

  4. Oli Bartsch merged patch set 2 11/12/24, 08:11