Review main Merged

8702[BUGFIX] Marker not removed from file module

Ernesto Baschny CR +2 V +2 Easy +2 −0 updated 06/03/13, 20:49

Commit message

If bookmarks are disabled, the ##SHORTCUT## marker is still shown.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Markus Klein +1
    • Ernesto Baschny +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Markus Klein +1
    • Ernesto Baschny +1

Files 1

Review log 11

  1. Markus Klein commented on patch set 1 01/26/12, 14:05

    Looks good to me, but someone else must approve Would you mind if I shorten the message subject line a bit?
  2. Markus Klein uploaded patch set 2 01/26/12, 14:05

  3. Markus Klein commented on patch set 2 01/26/12, 14:05

    Verified; Looks good to me, but someone else must approve 4.5 is not affected.
  4. Tolleiv Nietsch commented on patch set 3 V 0 01/26/12, 14:05

    by team member; Looks good to me, approved
  5. Markus Klein commented on patch set 3 01/26/12, 14:05

    Verified; Looks good to me, but someone else must approve Sorry, of course 4.5 is affected too.
  6. Markus Klein uploaded patch set 3 01/26/12, 14:05

  7. Mr. Jenkins commented on patch set 1 01/26/12, 14:05

  8. Mr. Jenkins commented on patch set 2 01/26/12, 14:05

  9. Mr. Jenkins commented on patch set 3 01/26/12, 14:05

  10. Ernesto Baschny commented on patch set 3 01/26/12, 14:05

    Verified; Looks good to me, but someone else must approve I in fact do mind shortening the commit message for no reason just for the sake of having it short. The information that it's the "###SHORTCUT###" marker to me is the most important stuff that one might want to see. The 52 limit is of course GIT-ish, but we agreed that it should be below "80 chars" at any case. The oneline commit message is displayed in the changelog, in the Release Notes (Wiki), so in my opinion it should carry the most important keywords one might later on "search for" when dealing with a particular bug. Anyhow, let's get this no-brainer merged anyway thanks!
  11. Ernesto Baschny merged patch set 3 01/26/12, 14:05