Review main Merged

8704[BUGFIX] Install Tool: Settings added by extensions can be edited (duplicating them)

Ernesto Baschny CR +2 V +2 Easy +30 −4 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Ernesto Baschny +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Ernesto Baschny +2
    • Wouter Wolters +1
    • Susi Moog +1

Files 2

Review log 12

  1. Ernesto Baschny uploaded patch set 2 02/13/12, 21:58

  2. Ernesto Baschny commented on patch set 2 02/13/12, 21:58

    I've just updated the commit message in patchset 2 (fitting it in 80 chars). Code is unchanged.
  3. Ernesto Baschny commented on patch set 2 V 0 02/13/12, 21:58

    by team member; Looks good to me, approved
  4. Ernesto Baschny merged patch set 2 02/13/12, 21:58

  5. Tolleiv Nietsch commented on patch set 1 02/13/12, 21:58

    The [GLOBAL] is duplicated everywhere - seems that it would make more sense to pass an additional parameter ($condition) along which defaults to "[GLOBAL]" to avoid the duplication. Don't want to make it a blocker to get it integrated but wanted to mention it.
  6. Markus Klein commented on patch set 1 02/13/12, 21:58

    (1 inline comment)
    If a new change set is pushed, please consider shortening this line to comply with formatting guides.
  7. Susi Moog commented on patch set 2 02/13/12, 21:58

    Verified; Looks good to me, but someone else must approve
  8. Simon Schaufelberger commented on patch set 1 02/13/12, 21:58

    Looks good to me, but someone else must approve looks good so far without testing it!
  9. Mr. Jenkins commented on patch set 1 02/13/12, 21:58

  10. Mr. Jenkins commented on patch set 2 02/13/12, 21:58

  11. Mr. Jenkins commented on patch set 2 02/13/12, 21:58

  12. Wouter Wolters commented on patch set 2 02/13/12, 21:58

    Verified; Looks good to me, but someone else must approve