Review main Merged

87270[BUGFIX] Register styleguide ext:form BE TS globally

Christian Kuhn CR +2 V +2 Normal +93 −113 updated 11/28/24, 12:06

Commit message

Extbase based backend modules that are not within page
scope and have no page uid try to guess a page uid in
extbase BackendConfigurationManager by picking the first
site they can find in the page tree to calculate
TypoScript.

This is clumsy for a long time already since it depends
on the first site to include "global" TypoScript either
via a sys_template record, or a site set. This became
even more complex in v13 since sites based on site sets
no longer read ext_typoscript_setup.txt files.

The backend module of the form extension is a victim here, in
particular to register additional yaml positions delivered
by extensions.

The patch adapts the ext:styleguide to register its ext:form
backend extbase module configuration TypoScript globally
using ExtensionManagementUtility::addTypoScriptSetup() in
its ext_localconf.php, so it no longer depends on TS of
the "first" site.

The ext:form documentation is adapted to declare this
strategy as best practice.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 7

Review log 1014

  1. Christian Kuhn uploaded patch set 1 11/28/24, 10:07

  2. Christian Kuhn uploaded patch set 2 11/28/24, 10:08

  3. core-ci voted on patch set 2 V +1 11/28/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70298

  4. core-ci voted on patch set 1 V +1 11/28/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70297

  5. Christian Kuhn updated the commit message in patch set 3 V +1 11/28/24, 10:18

  6. core-ci voted on patch set 3 V +1 11/28/24, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70300

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 11/28/24, 10:51

  8. Garvin Hicking commented on patch set 3 CR -1 11/28/24, 10:59

    working on RST formatting
  9. Garvin Hicking commented on patch set 4 CR +1 V +1 11/28/24, 11:07

    Published edit on patch set 3.
  10. Garvin Hicking voted on patch set 4 CR +1 V +1 11/28/24, 11:12

  11. core-ci voted on patch set 4 V +1 11/28/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70301

  12. Stefan Bürk voted on patch set 4 CR +1 V +1 11/28/24, 11:23

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 11/28/24, 12:06

  14. Christian Kuhn merged patch set 5 11/28/24, 12:06